Improve infra-run portfolio credibility

infra-run/scripts/bash/gpfs/00_env.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 TIMESTAMP="${TIMESTAMP:-$(date +%Y%m%d_%H%M%S)}"
 DRY_RUN="${DRY_RUN:-true}"

infra-run/scripts/bash/gpfs/01_cluster_overview.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh

infra-run/scripts/bash/gpfs/02_precheck_gpfs.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh

infra-run/scripts/bash/gpfs/03_detect_new_disks.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh

infra-run/scripts/bash/gpfs/04_create_nsd_stanza.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh

infra-run/scripts/bash/gpfs/05_add_nsd_to_filesystem.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh
@@ -43,8 +41,13 @@ fi
 
 warning "Adding NSDs must be coordinated with storage, GPFS, application, and change-management teams."
 section "Planned GPFS changes"
-ok "DRY-RUN: mmcrnsd -F $NSD_STANZA"
-ok "DRY-RUN: mmadddisk $FILESYSTEM -F $NSD_STANZA"
+if [[ "$DRY_RUN" == "true" ]]; then
+  ok "DRY-RUN: mmcrnsd -F $NSD_STANZA"
+  ok "DRY-RUN: mmadddisk $FILESYSTEM -F $NSD_STANZA"
+else
+  warning "EXECUTE: mmcrnsd -F $NSD_STANZA"
+  warning "EXECUTE: mmadddisk $FILESYSTEM -F $NSD_STANZA"
+fi
 
 confirm_execute "create NSDs and add disks to $FILESYSTEM"
 

infra-run/scripts/bash/gpfs/06_rebalance_filesystem.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh
@@ -48,7 +46,11 @@ if [[ "$BACKGROUND" == "true" ]]; then
     mmrestripefs "$FILESYSTEM" -b 2>&1 | tee -a "$LOG_FILE" &
   fi
 else
-  ok "DRY-RUN: mmrestripefs $FILESYSTEM -b"
+  if [[ "$DRY_RUN" == "true" ]]; then
+    ok "DRY-RUN: mmrestripefs $FILESYSTEM -b"
+  else
+    warning "EXECUTE: mmrestripefs $FILESYSTEM -b"
+  fi
   confirm_execute "restripe for $FILESYSTEM"
   if [[ "$DRY_RUN" == "false" ]]; then
     run_cmd mmrestripefs "$FILESYSTEM" -b

infra-run/scripts/bash/gpfs/07_postcheck_gpfs.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh

infra-run/scripts/bash/gpfs/08_generate_report.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh

infra-run/scripts/bash/gpfs/README.md

@@ -1,6 +1,6 @@
 # GPFS / IBM Spectrum Scale Filesystem Expansion Toolkit
 
-Safe, sanitized Bash examples for planning and executing a GPFS / IBM Spectrum Scale filesystem expansion. The scripts are written as portfolio-grade operational tooling for a Linux Infrastructure Engineer: conservative defaults, clear validation, dry-run behavior, and explicit operator confirmation before changes.
+Safe, sanitized Bash examples for planning and executing a GPFS / IBM Spectrum Scale filesystem expansion. The scripts are written as readable operational examples for a Linux Infrastructure Engineer: conservative defaults, clear validation, dry-run behavior, and explicit operator confirmation before changes.
 
 These scripts are examples. Exact GPFS commands, flags, quorum practices, failure-group design, and storage naming standards vary by Spectrum Scale version and site policy.
 

infra-run/scripts/bash/gpfs/gpfs_extend_runbook.sh

@@ -1,7 +1,5 @@
 #!/usr/bin/env bash
-set -o errexit
-set -o nounset
-set -o pipefail
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 # shellcheck source=00_env.sh