Polish infrastructure portfolio projects

migration-validation-framework/validators/compare.py

@@ -37,9 +37,12 @@ class SnapshotComparator:
         # Compare each data type
         data_types = ["mounts", "services", "disk_usage"]
 
+        data1 = snapshot1.get("data", {})
+        data2 = snapshot2.get("data", {})
+
         for data_type in data_types:
-            if data_type in snapshot1.get("data", {}) and data_type in snapshot2.get("data", {}):
-                differences = self.compare_data_type(snapshot1["data"], snapshot2["data"], data_type)
+            if self.data_type_exists(data1, data_type) or self.data_type_exists(data2, data_type):
+                differences = self.compare_data_type(data1, data2, data_type)
                 comparison["differences"][data_type] = differences
 
         # Generate summary
@@ -50,10 +53,15 @@ class SnapshotComparator:
 
         # Validation results
         comparison["validation_results"] = self.validate_changes(comparison["differences"])
+        comparison["validation_results"]["result"] = "PASS" if comparison["validation_results"]["passed"] else "FAIL"
 
         logger.info("Snapshot comparison completed")
         return comparison
 
+    def data_type_exists(self, systems: Dict[str, Any], data_type: str) -> bool:
+        """Return true when at least one system has the requested collector data."""
+        return any(data_type in system_data for system_data in systems.values())
+
     def compare_data_type(self, data1: Dict[str, Any], data2: Dict[str, Any], data_type: str) -> Dict[str, Any]:
         """Compare a specific data type between two snapshots."""
         differences = {}
@@ -237,7 +245,7 @@ class SnapshotComparator:
     def generate_summary(self, differences: Dict[str, Any]) -> Dict[str, Any]:
         """Generate a summary of all differences."""
         summary = {
-            "total_systems": len(differences),
+            "total_systems": 0,
             "systems_with_changes": 0,
             "total_changes": 0,
             "changes_by_type": {},
@@ -259,6 +267,8 @@ class SnapshotComparator:
                 summary["changes_by_type"][data_type] += change_count
                 summary["total_changes"] += change_count
 
+        summary["total_systems"] = len(system_change_counts)
+
         # Count systems with changes
         summary["systems_with_changes"] = len([s for s in system_change_counts.values() if s > 0])
 
@@ -488,4 +498,4 @@ class SnapshotComparator:
 def compare_snapshots(snapshot1: Dict[str, Any], snapshot2: Dict[str, Any]) -> Dict[str, Any]:
     """Main comparison function."""
     comparator = SnapshotComparator()
-    return comparator.compare_snapshots(snapshot1, snapshot2)
+    return comparator.compare_snapshots(snapshot1, snapshot2)